Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add creation channels to remaining endpoints #1496

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Add creation channels to remaining endpoints #1496

merged 3 commits into from
Jan 23, 2025

Conversation

martyn-w
Copy link
Contributor

@martyn-w martyn-w commented Jan 17, 2025 •
edited
Loading

Adds creation channels to:

  • Callback API endpoint
  • Schools Experience endpoint
  • Events endpoint

@github-actions github-actions bot added VisualCSharp Visual C # Test Test scripts and harnesses labels Jan 17, 2025
@martyn-w
Copy link
Contributor Author

Hi @spanersoraferty, SonarCloud Code Analysis is complaining about duplicated code in this PR... I was wondering if you could help me with this - perhaps by moving the duplicated method AddCandidateCreationChannel() to its own class and either inherit / or use it in a composition?

@spencerohegartyDfE
Made changes to force code reuse and keep SonarQube happy
2702912
@spencerohegartyDfE
Removed ContactChannelCreations object which encapsulated list of Con…
2ae66ef 
…tactChannelCreation types given the attribute was masked from the underlying reflection property values extractor.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@martyn-w martyn-w marked this pull request as ready for review January 23, 2025 10:56
@martyn-w martyn-w merged commit 72789e3 into add-creation-channel-model Jan 23, 2025
13 checks passed
@martyn-w martyn-w deleted the add-remaining-creation-channel-endpoints branch January 23, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spanersoraferty spanersoraferty spanersoraferty approved these changes

Assignees
No one assigned
Labels
Test Test scripts and harnesses VisualCSharp Visual C #
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martyn-w @spanersoraferty @spencerohegartyDfE