So/review sentry exception logging in the api #1498
Conversation
github-actions
bot
added
VisualCSharp
|
| } | ||
|
|
||
| _logger.LogInformation("UpsertCandidateJob - Started ({Attempt})", AttemptInfo(context, _contextAdapter)); | ||
| _logger.LogInformation("UpsertCandidateJob - Payload {Payload}", Redactor.RedactJson(json)); | ||
| _logger.LogInformation("UpsertCandidateJob - Started ({Attempt}) {CorrelationId}", AttemptInfo(context, _contextAdapter), correlationId); |
There was a problem hiding this comment.
could the correlation Id be made more prominent in the log so it is easy to distinguish from all the other GUIDs? How about:
CID-162cdb97-32ba-4efc-b7f8-7a2ad87b8d39[162cdb97-32ba-4efc-b7f8-7a2ad87b8d39](162cdb97-32ba-4efc-b7f8-7a2ad87b8d39)
There was a problem hiding this comment.
No problem, happy to do whatever you think may help. Leave it with me and I'll send you the output once I've applied the change to see if things look right.
| @@ -10,9 +10,18 @@ | |||
| "WriteTo": [ | |||
| { | |||
| "Name": "Console" | |||
| }, | |||
| { | |||
| "Name": "File", | |||
There was a problem hiding this comment.
could this be a local dev setting, rather than in the main app settings? I don't think this will work on production
There was a problem hiding this comment.
Actually, this should be removed. Thought I had, leave it with me and I'll sort.
I've limited the use of the correlation ID to the teacher advisor sign-up endpoint (as discussed) to limit the potential for issues if any problems occur. I've also not been able to best the filter attribute, it is possible but I cannot mock the hangfire context because they've neglected to apply interfaces, or make class methods generic. We could use a library like Typemock but not sure if this will play nicely with the CICD pipeline out of the box.
If theses changes prove stable we can raise a second, follow-on ticket to complete the work to apply this logging behaviour across the remaining endpoints.