Add simple feature flag for feedback that can be enabled / disabled per env #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StackedPancakez
temporarily deployed
to
review_aks
GitHub Actions
Inactive
StackedPancakez
temporarily deployed
to
Review
GitHub Actions
Inactive
StackedPancakez
force-pushed
the
create-simple-feedback-feature-flag-for-env-migration
branch
from
7445dea to
a4e0a01
Compare
StackedPancakez
temporarily deployed
to
review_aks
GitHub Actions
Inactive
StackedPancakez
temporarily deployed
to
Review
GitHub Actions
Inactive
Base automatically changed from
repurpose-adviser-feedback-form-to-replace-git-feedback-form
to
master
October 31, 2023 11:24
…er environment in preparation for disabling feedback during the production environment migration
StackedPancakez
force-pushed
the
create-simple-feedback-feature-flag-for-env-migration
branch
from
a4e0a01 to
bce1cc2
Compare
StackedPancakez
temporarily deployed
to
review_aks
GitHub Actions
Inactive
StackedPancakez
temporarily deployed
to
Review
GitHub Actions
Inactive
|
AKS Review app deployed to https://get-into-teaching-app-review-3655.test.teacherservices.cloud |
|
Review app deployed to https://review-get-into-teaching-app-3655.london.cloudapps.digital |
|
Kudos, SonarCloud Quality Gate passed! |
StackedPancakez
deleted the
create-simple-feedback-feature-flag-for-env-migration
branch
StackedPancakez
temporarily deployed
to
review_aks
GitHub Actions
Inactive
StackedPancakez
temporarily deployed
to
Review
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
4926
Context
A migration of the production environment from PAAS to AKS will take place next week. For this, we want to temporarily disable anyone accessing or using the feedback pages.
Changes proposed in this pull request
Add a simple feature flag that can be set per environment to enable / disable access to the feedback pages.
Guidance to review
Currently development (and therefore also review apps) are set with the feature flag turned on, so testing should be that you are able to use the feedback functionality with no issues, if you would like to test what will happen when it is turned off, please let me know and I can push a change that turns it off for the development environment as well (which I will revert before merging).