Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to the internships page #3657

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Minor improvements to the internships page #3657

merged 3 commits into from
Oct 31, 2023

Conversation

philspraydfe
Copy link
Contributor

Trello card

https://trello.com/c/99whTIhl

Context

We have reviewed the internships page and have agreed to make minor content changes to the page.

Changes proposed in this pull request

  • tweak to the header
  • added a line to explain there are listings on the page
  • added an instruction to select a region

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code content Content changes labels Oct 30, 2023
@philspraydfe philspraydfe temporarily deployed to review_aks October 30, 2023 09:48 — with GitHub Actions Inactive
@philspraydfe philspraydfe temporarily deployed to Review October 30, 2023 09:48 — with GitHub Actions Inactive
@github-actions github-actions bot added Review Review_v2 Create AKS review app labels Oct 30, 2023
@StackedPancakez StackedPancakez temporarily deployed to review_aks October 30, 2023 10:46 — with GitHub Actions Inactive
@StackedPancakez StackedPancakez temporarily deployed to Review October 30, 2023 10:46 — with GitHub Actions Inactive
@github-actions
Copy link

Review app deployed to https://review-get-into-teaching-app-3657.london.cloudapps.digital

@github-actions
Copy link

AKS Review app deployed to https://get-into-teaching-app-review-3657.test.teacherservices.cloud

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

97.2% 97.2% Coverage
0.2% 0.2% Duplication

gemmadallmandfe
gemmadallmandfe approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@philspraydfe philspraydfe merged commit bf1b9a0 into master Oct 31, 2023
25 checks passed
@philspraydfe philspraydfe deleted the minor-improvements-to-the-internships-page branch October 31, 2023 11:51
@philspraydfe philspraydfe temporarily deployed to Review October 31, 2023 11:51 — with GitHub Actions Inactive
@philspraydfe philspraydfe temporarily deployed to review_aks October 31, 2023 11:51 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemmadallmandfe gemmadallmandfe gemmadallmandfe approved these changes

Assignees
No one assigned
Labels
content Content changes Review_v2 Create AKS review app Review ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philspraydfe @gemmadallmandfe @StackedPancakez