Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove code that starts and appends chat widget to the DOM" #3660

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

StackedPancakez
Copy link
Contributor

@StackedPancakez StackedPancakez commented Oct 30, 2023

Trello card

4847

Changes proposed in this pull request

Reverts #3630

Reinstates code to allow the widget to display.

Adds websocket endpoint to whitelist to enable messaging.

@StackedPancakez StackedPancakez self-assigned this Oct 30, 2023
@github-actions github-actions bot added the test label Oct 30, 2023
@StackedPancakez StackedPancakez temporarily deployed to review_aks October 30, 2023 17:11 — with GitHub Actions Inactive
@StackedPancakez StackedPancakez temporarily deployed to Review October 30, 2023 17:11 — with GitHub Actions Inactive
@StackedPancakez StackedPancakez temporarily deployed to Review October 30, 2023 17:12 — with GitHub Actions Inactive
@StackedPancakez StackedPancakez temporarily deployed to review_aks October 30, 2023 17:12 — with GitHub Actions Inactive
@github-actions github-actions bot added Review Review_v2 Create AKS review app labels Oct 30, 2023
@StackedPancakez StackedPancakez force-pushed the revert-3630-remove-widget-funcationality branch from ec37aae to 93034bb Compare November 1, 2023 09:22
@StackedPancakez StackedPancakez temporarily deployed to review_aks November 1, 2023 09:27 — with GitHub Actions Inactive
@StackedPancakez StackedPancakez temporarily deployed to Review November 1, 2023 09:27 — with GitHub Actions Inactive

This comment was marked as outdated.

asatwal
asatwal previously approved these changes Nov 1, 2023
Copy link
Contributor

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

asatwal
asatwal previously approved these changes Nov 8, 2023
Copy link
Contributor

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@StackedPancakez StackedPancakez force-pushed the revert-3630-remove-widget-funcationality branch from a1e8efe to 679d73a Compare November 13, 2023 11:40
Copy link

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

96.2% 96.2% Coverage
0.2% 0.2% Duplication

Copy link
Contributor

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to be merged

@StackedPancakez StackedPancakez merged commit 5e55c4c into master Nov 14, 2023
21 checks passed
@StackedPancakez StackedPancakez deleted the revert-3630-remove-widget-funcationality branch November 14, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Review_v2 Create AKS review app Review ruby Pull requests that update Ruby code Style test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants