Non-UK fees and funding integration test #3746

laurahermionetennant92 · 2023-12-07T14:31:13Z

Bursaries and scholarships cut, link inserted

Trello card

https://trello.com/c/YQejKWOi/5684-updated-non-uk-fees-and-financial-support-page

Context

Changes proposed in this pull request

clearer fees
clearer help for those with settled status
links back to domestic bursary and scholarship page to avoid replicating content on international and domestic pages

Guidance to review

Bursaries and scholarships cut, link inserted

sonarqubecloud · 2023-12-07T14:47:53Z

SonarCloud Quality Gate failed.

1 Bug
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

96.2% Coverage
0.2% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

gemmadallmandfe · 2024-01-26T08:51:47Z

Closing this one as discussed with @laurahermionetennant92 as we don't need it open continually - can always re-open in future if needed

Add settled status to fees and funding page

Remove student loans as covered above

Fees

fix bullets

Eligibility bullets

MaxineCl · 2024-02-28T09:49:17Z

app/views/content/non-uk-teachers/fees-and-funding-for-non-uk-trainees.md


-You can apply for a [salaried teacher training course](/funding-and-support/salaried-teacher-training). On this type of course, you will not pay a fee, and you can earn money while you train in a school. However, these courses are limited in number and very competitive. 
+* cost £36,000 at their most expensive


@laurahermionetennant92 think we tend to say a maximum of then the amount. I don't know if expensive might put people off?

Yeah that's better

MaxineCl · 2024-02-28T09:50:22Z

app/views/content/non-uk-teachers/fees-and-funding-for-non-uk-trainees.md


-You can apply for a [salaried teacher training course](/funding-and-support/salaried-teacher-training). On this type of course, you will not pay a fee, and you can earn money while you train in a school. However, these courses are limited in number and very competitive. 
+* cost £36,000 at their most expensive
+* average at £14,765 


@laurahermionetennant92 an average of £14,756?

@laurahermionetennant92 one tiny tweak, sorry. In the updated version under Teacher training fees. We don't need to repeat cost in the bullets. It could just say Fees cost:

Fees:

cost an average of £14,765
cost a maximum of about £36,000

MaxineCl · 2024-02-28T09:56:22Z

app/views/content/non-uk-teachers/fees-and-funding-for-non-uk-trainees.md

+* cost £36,000 at their most expensive
+* average at £14,765 
+
+You’ll also have to cover your living costs. 


@laurahermionetennant92 would it make more sense to have this line of copy before the fees bullet points (so after Teacher training fees for non-UK candidates vary between training providers.)?

As the sentence after it living costs is talking about help with fees. So it keeps all the fees bit together.

I've put at end so it doesn't interfere with 'fees vary' and the actual fees

MaxineCl · 2024-02-28T09:58:29Z

app/views/content/non-uk-teachers/fees-and-funding-for-non-uk-trainees.md

+
+* [bursaries and scholarships in the subjects offered to UK citizens](/funding-and-support/scholarships-and-bursaries) 
+
+[How to apply for student loans, bursaries and scholarships](#how-to-apply-for-student-loans-bursaries-and-scholarships).


@laurahermionetennant92 do we need this link here? As there's a section later on how to apply for student loans, bursaries and scholarships?

I think helpful as it's still a long page

laurahermionetennant92 · 2024-02-28T15:35:54Z

This one is good to go @MaxineCl

martyn-w · 2024-02-29T14:44:25Z

Hi @laurahermionetennant92 I've just pulled in the latest master branch into your PR; please synchronise with github and then update your libraries with bundle install and yarn install.

I note there is a failing test:

Failure/Error: expect(paths).to(include(uri.path), "invalid path #***href*** on page #***sp.path***")
invalid path /non-uk-teachers/visas-for-non-uk-trainees/#skilled-worker-visa on page /non-uk-teachers/fees-and-funding-for-non-uk-trainees

to fix this, just update the URL on page /non-uk-teachers/fees-and-funding-for-non-uk-trainees from /non-uk-teachers/visas-for-non-uk-trainees/#skilled-worker-visa to /non-uk-teachers/visas-for-non-uk-trainees#skilled-worker-visa

Broken link

MaxineCl · 2024-03-04T11:35:29Z

app/views/content/non-uk-teachers/fees-and-funding-for-non-uk-trainees.md


-You can apply for a [salaried teacher training course](/funding-and-support/salaried-teacher-training). On this type of course, you will not pay a fee, and you can earn money while you train in a school. However, these courses are limited in number and very competitive. 
+* cost an average of £14,765


@laurahermionetennant92 don't need cost in the bullet points. It could say Fees cost:

MaxineCl · 2024-03-04T11:35:56Z

app/views/content/non-uk-teachers/fees-and-funding-for-non-uk-trainees.md

+
+Non-UK citizens can apply for a [salaried teacher training course](/funding-and-support/salaried-teacher-training). On this type of course, you will not pay a fee, and you can earn money while you train in a school. However, these courses are limited in number and very competitive. 
+
+You will also need a [visa or immigration status](/non-uk-teachers/visas-for-non-uk-trainees#skilled-worker-visa) allowing you to work in the UK.


@laurahermionetennant92 You'll

MaxineCl · 2024-03-04T11:37:26Z

app/views/content/non-uk-teachers/fees-and-funding-for-non-uk-trainees.md

 * extra help if you have a disability, children or an adult dependant

-Talk to your training provider about:
+If you are eligible for student loans, you will also usually be eligible: 


@laurahermionetennant92 you're and you'll

MaxineCl · 2024-03-04T11:40:11Z

app/views/content/non-uk-teachers/train-to-teach-in-england-as-an-international-student.md

+Teacher training fees for non-UK candidates vary between training providers.
+
+Fees:
+


@laurahermionetennant92 as above Fees cost: and then can lose cost after each bullet point

MaxineCl · 2024-03-04T11:40:48Z

app/views/content/non-uk-teachers/train-to-teach-in-england-as-an-international-student.md

+* cost a maximum of about £36,000
+* cost an average of £14,765
+
+You’ll also have to cover your living costs.

 If you are planning on training to teach languages and physics, you could be eligible for financial help worth up to £40,000, including an international relocation payment worth £10,000.


@laurahermionetennant92 you're
international relocation payment (IRP)

Maxine tweak

reverse order of fees

Maxine tweak

laurahermionetennant92 · 2024-03-04T13:56:09Z

@MaxineCl Don't know how I missed those other comments, fixed now!

final typos

github-actions · 2024-03-04T14:03:09Z

Review app deployed to https://get-into-teaching-app-review-3746.test.teacherservices.cloud

sonarqubecloud · 2024-03-04T14:04:27Z

Quality Gate passed

Issues
7 New issues
10 Accepted issues

Measures
0 Security Hotspots
96.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Bursaries and scholarships cut, link inserted

76237ca

Bursaries and scholarships cut, link inserted

laurahermionetennant92 temporarily deployed to review_aks December 7, 2023 14:36 — with GitHub Actions Inactive

github-actions bot added the Review_v2 Create AKS review app label Dec 7, 2023

laurahermionetennant92 changed the title ~~Bursaries and scholarships cut, link inserted~~ Non-UK fees and funding integration test Dec 11, 2023

gemmadallmandfe closed this Jan 26, 2024

gemmadallmandfe temporarily deployed to review January 26, 2024 08:51 — with GitHub Actions Inactive

laurahermionetennant92 reopened this Jan 29, 2024

github-actions bot added the content Content changes label Jan 29, 2024

laurahermionetennant92 temporarily deployed to review January 29, 2024 15:39 — with GitHub Actions Inactive

github-actions bot added the Review label Jan 29, 2024

Update fees-and-funding-for-non-uk-trainees.md

700503b

laurahermionetennant92 temporarily deployed to review January 29, 2024 15:53 — with GitHub Actions Inactive

Add settled status to fees and funding page

73ee023

Add settled status to fees and funding page

laurahermionetennant92 temporarily deployed to review February 20, 2024 16:19 — with GitHub Actions Inactive

Remove student loans as covered above

24a3002

Remove student loans as covered above

laurahermionetennant92 temporarily deployed to review February 20, 2024 16:47 — with GitHub Actions Inactive

Fees

df30e4a

Fees

laurahermionetennant92 temporarily deployed to review February 21, 2024 14:08 — with GitHub Actions Inactive

fix bullets

cd58a2b

fix bullets

laurahermionetennant92 temporarily deployed to review February 21, 2024 14:39 — with GitHub Actions Inactive

Eligibility bullets

ee061ef

Eligibility bullets

laurahermionetennant92 temporarily deployed to review February 21, 2024 15:11 — with GitHub Actions Inactive

laurahermionetennant92 requested a review from MaxineCl February 27, 2024 09:13

laurahermionetennant92 marked this pull request as ready for review February 27, 2024 10:59

MaxineCl reviewed Feb 28, 2024

View reviewed changes

laurahermionetennant92 temporarily deployed to review February 28, 2024 15:16 — with GitHub Actions Inactive

Update fees-and-funding-for-non-uk-trainees.md

e9590d0

laurahermionetennant92 temporarily deployed to review February 28, 2024 15:26 — with GitHub Actions Inactive

Merge branch 'master' into Non-UK-fees-and-funding-integration-test

a21182d

martyn-w temporarily deployed to review February 29, 2024 14:45 — with GitHub Actions Inactive

Broken link

552615f

Broken link

laurahermionetennant92 temporarily deployed to review March 4, 2024 09:55 — with GitHub Actions Inactive

laurahermionetennant92 requested a review from MaxineCl March 4, 2024 10:12

MaxineCl reviewed Mar 4, 2024

View reviewed changes

Maxine tweak

1b9c25f

Maxine tweak

laurahermionetennant92 temporarily deployed to review March 4, 2024 11:55 — with GitHub Actions Inactive

reverse order of fees

df5b5d2

reverse order of fees

laurahermionetennant92 temporarily deployed to review March 4, 2024 12:35 — with GitHub Actions Inactive

Maxine tweak

0262941

Maxine tweak

laurahermionetennant92 temporarily deployed to review March 4, 2024 13:50 — with GitHub Actions Inactive

final typos

928b65e

final typos

laurahermionetennant92 temporarily deployed to review March 4, 2024 14:01 — with GitHub Actions Inactive

MaxineCl approved these changes Mar 4, 2024

View reviewed changes

laurahermionetennant92 merged commit bc8e16c into master Mar 4, 2024
26 checks passed

laurahermionetennant92 deleted the Non-UK-fees-and-funding-integration-test branch March 4, 2024 14:17

laurahermionetennant92 temporarily deployed to review March 4, 2024 14:17 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Non-UK fees and funding integration test #3746

Non-UK fees and funding integration test #3746

laurahermionetennant92 commented Dec 7, 2023 •

edited

Loading

sonarqubecloud bot commented Dec 7, 2023

gemmadallmandfe commented Jan 26, 2024

MaxineCl Feb 28, 2024 •

edited

Loading

laurahermionetennant92 Feb 28, 2024

MaxineCl Feb 28, 2024

MaxineCl Feb 29, 2024

MaxineCl Feb 28, 2024

laurahermionetennant92 Feb 28, 2024

MaxineCl Feb 28, 2024

laurahermionetennant92 Feb 28, 2024

laurahermionetennant92 commented Feb 28, 2024

martyn-w commented Feb 29, 2024

MaxineCl Mar 4, 2024

MaxineCl Mar 4, 2024

MaxineCl Mar 4, 2024

MaxineCl Mar 4, 2024

MaxineCl Mar 4, 2024

laurahermionetennant92 commented Mar 4, 2024

github-actions bot commented Mar 4, 2024

sonarqubecloud bot commented Mar 4, 2024


		You can apply for a [salaried teacher training course](/funding-and-support/salaried-teacher-training). On this type of course, you will not pay a fee, and you can earn money while you train in a school. However, these courses are limited in number and very competitive.
		* cost £36,000 at their most expensive


		* [bursaries and scholarships in the subjects offered to UK citizens](/funding-and-support/scholarships-and-bursaries)

		[How to apply for student loans, bursaries and scholarships](#how-to-apply-for-student-loans-bursaries-and-scholarships).


		You can apply for a [salaried teacher training course](/funding-and-support/salaried-teacher-training). On this type of course, you will not pay a fee, and you can earn money while you train in a school. However, these courses are limited in number and very competitive.
		* cost an average of £14,765


		Non-UK citizens can apply for a [salaried teacher training course](/funding-and-support/salaried-teacher-training). On this type of course, you will not pay a fee, and you can earn money while you train in a school. However, these courses are limited in number and very competitive.

		You will also need a [visa or immigration status](/non-uk-teachers/visas-for-non-uk-trainees#skilled-worker-visa) allowing you to work in the UK.

		Teacher training fees for non-UK candidates vary between training providers.

		Fees:

Non-UK fees and funding integration test #3746

Non-UK fees and funding integration test #3746

Conversation

laurahermionetennant92 commented Dec 7, 2023 • edited Loading

Trello card

Context

Changes proposed in this pull request

Guidance to review

sonarqubecloud bot commented Dec 7, 2023

gemmadallmandfe commented Jan 26, 2024

MaxineCl Feb 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

laurahermionetennant92 commented Feb 28, 2024

martyn-w commented Feb 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

laurahermionetennant92 commented Mar 4, 2024

github-actions bot commented Mar 4, 2024

sonarqubecloud bot commented Mar 4, 2024

Quality Gate passed

laurahermionetennant92 commented Dec 7, 2023 •

edited

Loading

MaxineCl Feb 28, 2024 •

edited

Loading