Fix height of images in landing hero component #4408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Review app deployed to https://get-into-teaching-app-review-4408.test.teacherservices.cloud |
gemmadallmandfe
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Looks good to me from a front end perspective
@jenhadfield-dfe Are you happy with this?
@spencerldixon Can we get this merged today (after a tech review)?
jenhadfield-dfe
approved these changes
Dec 9, 2024
looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/l5tDsv5z/6812-change-landingherocomponent-to-fix-page-load-issues-with-images?filter=member:spencerldixon
Context
We identified an issue with page loading when pages contain a header with images (see https://trello.com/c/dhYNjDNm )
We want to amend the LandingHeroComponent to reserve the amount of space we want the image to be rendered at (regardless of the actual size of the image)
Changes proposed in this pull request
Guidance to review