Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create how to become a teacher from teaching assistant page #4447

Closed
wants to merge 11 commits into from
Closed

create how to become a teacher from teaching assistant page #4447

wants to merge 11 commits into from

Conversation

joegibb
Copy link
Collaborator

@joegibb joegibb commented Dec 20, 2024

https://trello.com/c/R7ciiFI6

People are searching for how to become a teacher from a teaching assistant so we are creating a new page to give them guidance

@github-actions github-actions bot added ruby Pull requests that update Ruby code content Content changes labels Dec 20, 2024
@github-actions github-actions bot added the Review label Jan 2, 2025
emmaachesongray
emmaachesongray reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great start! I've put some suggestions and comments. If you haven't already, might be worth speaking to Amilcar about if we have any UR from TAs. Are there any misconceptions they have or important points we should make in the content.

app/views/content/life-as-a-teacher/change-careers/_categories.html.erb Outdated Show resolved Hide resolved
.../content/life-as-a-teacher/change-careers/how-to-become-a-teacher-from-teaching-assistant.md Outdated Show resolved Hide resolved
.../content/life-as-a-teacher/change-careers/how-to-become-a-teacher-from-teaching-assistant.md Outdated Show resolved Hide resolved
...s-a-teacher/change-careers/how-to-become-a-teacher-from-teaching-assistant/_article.html.erb Outdated Show resolved Hide resolved
...s-a-teacher/change-careers/how-to-become-a-teacher-from-teaching-assistant/_article.html.erb Show resolved Hide resolved
...s-a-teacher/change-careers/how-to-become-a-teacher-from-teaching-assistant/_article.html.erb Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Review app deployed to https://get-into-teaching-app-review-4447.test.teacherservices.cloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
12 New issues
10 Accepted issues

Measures
0 Security Hotspots
95.7% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

@joegibb joegibb closed this Jan 10, 2025
@joegibb
Copy link
Collaborator Author

joegibb commented Jan 10, 2025

Changing this page to just being updates on other pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemmadallmandfe gemmadallmandfe gemmadallmandfe left review comments

@emmaachesongray emmaachesongray Awaiting requested review from emmaachesongray

Assignees
No one assigned
Labels
content Content changes Review ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joegibb @gemmadallmandfe @emmaachesongray