find and apply promos

[jenhadfield-dfe]

Trello card

https://trello.com/c/vew5h4zh/7152-redesign-and-build-find-promo

Context

Changes proposed in this pull request

Guidance to review

[sonarqubecloud]

Quality Gate passed

Issues
11 New issues
8 Accepted issues

Measures
0 Security Hotspots
96.1% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarQube Cloud

[martyn-w]

👍 LGTM

[martyn-w]

NB: For the link rendered as button, add a role="button" to improve accessibility. And to make click tracking easier add a data-promo-type attribute, e.g.

<a class="button" role="button" data-promo-type="apply" href="https://www.gov.uk/apply-for-teacher-training">Apply for a <span>course</span></a>

[jenhadfield-dfe]

@martyn-w is there a way to set the default arguments here? so it makes it easier for content on the markdown file

eg. something like this? or is this the wrong place to do that? as i tried it and it didn't like it when i removed the arguments from the markdown file

def initialize(
  icon: "icon-school-black",
  link_text: "Apply for a course",
  link_target: "https://www.gov.uk/apply-for-teacher-training",
  title: "Start your application",
  text: "Create an account and start your application for a teacher training course.",
  hide_on_mobile: false,
  hide_on_tablet: false,
  hide_on_desktop: false
)
  super

[martyn-w]

Hi @jenhadfield-dfe i've just tested and your suggested fix for default arguments does work - you might need to restart the application to get the defaults to load. Could you try again?

[jenhadfield-dfe]

ah thank you! the minimum it will let me leave is just one argument in there, if i take them all out it breaks, but it's ok as long as i leave one in. Is this due to the line in the component:

def before_render
fail(ArgumentError, "a title or text/content must be present") if [title, text, content].all?(&:nil?)

[martyn-w]

yep - you could remove that constraint if it isn't required

[jenhadfield-dfe]

thanks, I've removed. But if i just put -

calls_to_action:
find:
name: find

in the markdown it still breaks, but if i keep one argument in it seems to work ok. It's not the end of the world to have one argument in there, but would be nice to have it as simple as possible

[jenhadfield-dfe]

@martyn-w is it everything below line 83 that needs removing from the spec files?

[github-actions]

Review app deployed to https://get-into-teaching-app-review-4476.test.teacherservices.cloud