Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create primary page and change misspelling of qualifications in files #4478

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

joegibb
Copy link
Collaborator

@joegibb joegibb commented Jan 10, 2025

https://trello.com/c/1R4yM9YS

We are creating an overview of teaching primary to help people decide whether they want to teach primary or secondary

@github-actions github-actions bot added ruby Pull requests that update Ruby code content Content changes labels Jan 10, 2025
Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments but think we're nearly there now!

Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of mini changes, then this is good to go

joegibb and others added 2 commits January 14, 2025 15:39
Copy link

@joegibb joegibb requested a review from Sarah-DfE January 14, 2025 15:54
Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@joegibb joegibb merged commit 65dd2ea into master Jan 14, 2025
27 checks passed
@joegibb joegibb deleted the create-a-primay-subject-page branch January 14, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes Review ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants