Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Non-UK heading to Outside the UK on Assessment only page #4487

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

sarahcrack
Copy link
Collaborator

Trello card

https://trello.com/c/y6TQaMjj/7227-change-non-uk-heading-to-outside-the-uk-on-assessment-only-page

Context

Eligibility for the Assessment only route is not based on citizenship - however the content on our Assessment only page is misleading in this respect. We need to update the Non-UK heading and jump link to say Outside of the UK.

Changes proposed in this pull request

Changed Non-UK to Outside of the UK in the below files and uploaded latest listings:

  • CSV file (columns Q and S)
  • rake task
  • erb template

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code content Content changes labels Jan 15, 2025
@gemmadallmandfe
Copy link
Contributor

@sarahcrack There is a failed test on here - the jump links still need changing by the looks of it?

app/views/content/train-to-be-a-teacher/assessment-only-route-to-qts.md
image

and the same in lib/tasks/support/assessment-only-route-to-qts.md.erb I think?

@sarahcrack sarahcrack marked this pull request as draft January 15, 2025 22:32
@sarahcrack
Copy link
Collaborator Author

@sarahcrack There is a failed test on here - the jump links still need changing by the looks of it?

app/views/content/train-to-be-a-teacher/assessment-only-route-to-qts.md image

and the same in lib/tasks/support/assessment-only-route-to-qts.md.erb I think?

Thanks @gemmadallmandfe! Will take a look at the jump links asap. I meant to convert this PR into a draft state as I didn't get a chance to look at the failing test so will dig into that when I am back from leave - have labelled as draft for the time being but happy for someone to pick this up if you need it this week :)

Copy link

@sarahcrack sarahcrack marked this pull request as ready for review January 20, 2025 10:25
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from a front-end perspective - I have tested the heading change, the jump link and the provider listing change re removing Bournemouth Bay from the Outside of the UK section

Happy for this to be merged after a tech review

Copy link
Contributor

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@sarahcrack sarahcrack merged commit 7dbf132 into master Jan 20, 2025
27 checks passed
@sarahcrack sarahcrack deleted the non-uk-heading-ao-page branch January 20, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes Review ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants