Bump kramdown from 2.4.0 to 2.5.1 #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [kramdown](https://github.com/gettalong/kramdown) from 2.4.0 to 2.5.1. - [Release notes](https://github.com/gettalong/kramdown/releases) - [Changelog](https://github.com/gettalong/kramdown/blob/master/doc/news.page) - [Commits](https://github.com/gettalong/kramdown/commits) --- updated-dependencies: - dependency-name: kramdown dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…like Kramdown's output required the test to include role=doc-noteref to validate accessible HTML
|
|
Review app deployed to https://get-into-teaching-app-review-4497.test.teacherservices.cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/KLUZlrRP/7288-bump-kramdown-from-240-to-251
Context
As part of the monthly dependency updates the bump of Kramdown was breaking the
accessible_footnotesspec test and needed further investigation.The original dependabot PR can be found here.
Changes proposed in this pull request
Adapted
accessible_footnotestest: it looks like Kramdown now requires the test to includerole="doc-noteref". This attribute is now added to footnote references in the generated HTML to improve accessibility, making it clearer for assistive technologies. The update ensures the test reflects the new output and validates accessibility.Guidance to review