Add green CTA partial to ResultsBoxComponent #4498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spencerldixon The green circle looks a bit squished on mobile - have tested in emulator but also on my phone
Is there anything we can do about this? Or merge this into the main branch now and fix this separately? |
|
Review app deployed to https://get-into-teaching-app-review-4498.test.teacherservices.cloud |
|
|
Responsiveness looks much better to me now - tested in emulator and on phone :-) Happy for you to merge this one into the main branch if you are @spencerldixon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Context
Changes proposed in this pull request
Guidance to review