Upload latest internships listings #4503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for the rake task to run. N.B. issue with St Peter's Catholic School Solihull due to missing school website link I think
… link so rake task ran successfully and info displayng correctly
|
Review app deployed to https://get-into-teaching-app-review-4503.test.teacherservices.cloud |
|
gemmadallmandfe
approved these changes
Jan 21, 2025
gemmadallmandfe
temporarily deployed
to
review
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/XH9oepv0/7224-upload-latest-internships-listings
Context
The internships team have some updated listing details that they would like to be uploaded.
Changes proposed in this pull request
Uploaded new listings via csv file and ran rake task.
Guidance to review
If seems that if the school website link is blank/empty on the csv file, the rake task may not run successfully producing a
MethodErrorand/or the information will display incorrectly. Does theInternshipProviderclass need adapting to handle this scenario (similar toAssessmentOnlyProvider)? In this instance we managed to add a link on the csv file to the school with a missing website url to avoid this error.