Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VWO SmartCode #4504

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Update VWO SmartCode #4504

merged 2 commits into from
Jan 23, 2025

Conversation

sarahcrack
Copy link
Collaborator

Trello card

https://trello.com/c/1CKwAqqZ/7233-update-vwo-smartcode

Context

When working with VWO to explore the trial on the form analytics, it was identified the VWO SmartCode currently implemented on the 'Get Into Teaching' website is outdated. To ensure optimal performance and compatibility with new features, we need to update the VWO SmartCode to version 2.1.

Changes proposed in this pull request

  • Updated code to version 2.1 as per VWO instructions in app/views/sections/_head.html.erb
  • Only change to original VWO code taken from the GiT account was to use an ENV variable for VWO ID (same as version 1.5).

Guidance to review

  • May possibly need some tweaks if new code is not working as expected (looks like it can be a bit fiddly!).

…om VWO was the line specifying the ID and using an env variable instead
@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Jan 22, 2025
Copy link

Copy link
Collaborator

@spencerldixon spencerldixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sarahcrack sarahcrack merged commit 9f21177 into master Jan 23, 2025
27 checks passed
@sarahcrack sarahcrack deleted the update-vwo-smart-code branch January 23, 2025 13:31
@sarahcrack
Copy link
Collaborator Author

Testing via VWO platform confirms the smart code has been updated to version 2.1 🙌🏻

Screenshot 2025-01-23 at 14 12 15

Screenshot 2025-01-23 at 14 12 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants