Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add creation channels to TTA, RTTA, Events, Mailing list and Callbacks #4507

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

martyn-w
Copy link
Contributor

@martyn-w martyn-w commented Jan 22, 2025

Trello card

Update GIT API to support creation channel structure

Context

This updates the GIT website to support new creation channel IDs on different funnels, including:

  • Return to Teaching Adviser (RTTA)
  • Teacher Training Adviser (TTA)
  • Mailing list signup
  • Events signup
  • Callback request

Changes proposed in this pull request

Multiple updates to support new channel params, as well as continuing to support existing channel params

Guidance to review

Test in the app then verify that the correct ContactChannelCreation record in the CRM (usually after a 20 minute synchronisation delay)

@github-actions github-actions bot added ruby Pull requests that update Ruby code test labels Jan 22, 2025
@martyn-w martyn-w changed the title Add creation channel to tta Add creation channels to TTA, RTTA, Events, Mailing list and Callbacks Jan 22, 2025
@martyn-w martyn-w marked this pull request as ready for review January 23, 2025 11:21
Copy link

Copy link
Collaborator

@spencerldixon spencerldixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review ruby Pull requests that update Ruby code test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants