-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add creation channels to TTA, RTTA, Events, Mailing list and Callbacks #4507
Open
martyn-w
wants to merge
12
commits into
master
Choose a base branch
from
add-creation-channel-to-tta
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martyn-w
changed the title
Add creation channel to tta
Add creation channels to TTA, RTTA, Events, Mailing list and Callbacks
Jan 22, 2025
Review app deployed to https://get-into-teaching-app-review-4507.test.teacherservices.cloud |
Quality Gate passedIssues Measures |
spencerldixon
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Update GIT API to support creation channel structure
Context
This updates the GIT website to support new creation channel IDs on different funnels, including:
Changes proposed in this pull request
Multiple updates to support new channel params, as well as continuing to support existing channel params
Guidance to review
Test in the app then verify that the correct ContactChannelCreation record in the CRM (usually after a 20 minute synchronisation delay)