Routes Wizard - No index everything except the index action #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerldixon
changed the title
|
@spencerldixon Can see the start page in the sitemap now and However, it is using the old default date as
|
|
|
Review app deployed to https://get-into-teaching-app-review-4513.test.teacherservices.cloud |
gemmadallmandfe
approved these changes
Jan 27, 2025
spencerldixon
added a commit
that referenced
this pull request
Jan 29, 2025
* Build initial question and results pages for routes wizard * Linting * Fix erb linting * Routes wizard results box (#4472) * recreated results box component and associated styling * added spec test for results box component * added results box to completed page of routes wizard * adjusted media query to improve responsiveness on mobile/tablet * Fixed spacing * removed results box from completed page of routes wizard * fixed indenting on results box css file --------- Co-authored-by: Spencer Dixon <[email protected]> * Create routes wizard logic (#4443) * WIP routes wizard logic * Completed matching logic for each route into teaching * Lint and exclude from orphan variables check * Ammend logic to support multiple answers to a question * WIP move logic to routes class * WIP adding tests * WIP adding tests * Add results box component * Add basic layout to completed page and add results boxes * Remove substitute values from most fields in results box * Amend routes mapping * Added not yet answers for routes mapping * Remove two routes * content updates for routes wizard results * Update config/routes_into_teaching.yml * removing separate Teach First info as covered on salaried results * Tweaks from policy and correcting a course length error * adding teach first back in * Sorting alignment out * Add sections to routes wizard completed page (#4490) * WIP routes wizard logic * Completed matching logic for each route into teaching * Lint and exclude from orphan variables check * Ammend logic to support multiple answers to a question * WIP move logic to routes class * WIP adding tests * WIP adding tests * Add results box component * Add basic layout to completed page and add results boxes * Remove substitute values from most fields in results box * Amend routes mapping * Added not yet answers for routes mapping * WIP adding page layout * Added mailing list form component * Change case-when to hash to satisfy rubocop * Swap order of privacy policy and next step button * Improve error messaging and spacing of results cards * Add start page and extra spacing to bottom of mailer form submit button * Linting * Update app/views/routes_into_teaching/steps/completed.html.erb Co-authored-by: Gemma Dallman <[email protected]> * Stylelint fixes to results box css * Added default heading tag to QuoteWithImageComponent and changed ResultsBoxComponent to render a h3 * Fix renaming of quote with image component attribute --------- Co-authored-by: Gemma Dallman <[email protected]> * Apply suggestions from code review * Add green CTA partial to ResultsBoxComponent (#4498) * Add cta component to routes wizard results box * Fix responsiveness of cta circle icon * sorting indent out * Routes wizard no results text (#4500) * Added no results text * updating link to help and support instead of TTA * Remove results override --------- Co-authored-by: Sarah-DfE <[email protected]> * updating links * Routes wizard start page (#4501) * Add start page content * updating start page content --------- Co-authored-by: Sarah-DfE <[email protected]> * updating teach first link text * updating links * updating after rebasing * updating content on results page 'you told us' bit * changin AO routes to AO route * making assessment lower-case * Sorting alignment out * removing teach first from salaried result * updating after policy review * Update config/routes_into_teaching.yml * Added early years and further education section (#4506) * Changed final step button text (#4512) * updating teach first description * Apply suggestions from code review * Move AO higher in results order * Update routes_into_teaching.yml * Update config/routes_into_teaching.yml * Routes wizard tracking (#4511) * Add answers to hidden divs in completed page * Linting * Routes Wizard - No index everything except the index action (#4513) * No index everything except the index action * Add routes to sitemap * Add routes path to page modification tracker * update order of degree question * slight padding change and h3 style * Update config/routes_into_teaching.yml * Update routes content ### Trello card https://trello.com/c/e2pnl2Bs/7297-test-the-routes-wizard ### Context ### Changes proposed in this pull request ### Guidance to review * Fix content errors * capitalise up to, and tweak options lead in text * Update app/views/routes_into_teaching/steps/completed.html.erb * Apply suggestions from code review Co-authored-by: Gemma Dallman <[email protected]> * Routes wizard back button (#4525) * Add back button on first step * Remove non uk expander component * Add aria hidden true label to hr separators in results box component * remove rogue full stop * expand QTS acronym * Update config/routes_into_teaching.yml * Amend AO wording on routes wizard * Add back mixing commits from other PR --------- Co-authored-by: sarahcrack <[email protected]> Co-authored-by: Sarah-DfE <[email protected]> Co-authored-by: emmaachesongray <[email protected]> Co-authored-by: Gemma Dallman <[email protected]> Co-authored-by: jenhadfield-dfe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/pfYp2AAi/7298-ensure-routes-wizard-start-page-is-added-to-sitemap-and-is-indexable?filter=member:spencerldixon
Context
We want to make sure the routes wizard start page (/routes-into-teaching) is indexable and appears in the sitemap
The other pages in the route wizard (including the completion page) should not be indexable, as landing in the middle of the wizard would be confusing
Changes proposed in this pull request
Guidance to review