-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update redirect and accessibility guidance #4519
Conversation
### Trello card ### Context ### Changes proposed in this pull request ### Guidance to review
docs/content.md
Outdated
|
||
Contractions can make content easier to read, but should be used consistently. | ||
|
||
Postive contractions like you'll, it's and we've can be used on Get Into Teaching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think but this would need confirming with @Sarah-DfE that we take a different approach on the pages for non-UK users?
Co-authored-by: Gemma Dallman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
NB outstanding question re contractions on Non-UK pages - I think we write out in full on Non-UK pages (eg you will
rather than you'll
) but @Sarah-DfE would be able to confirm
Co-authored-by: Gemma Dallman <[email protected]>
Review app deployed to https://get-into-teaching-app-review-4519.test.teacherservices.cloud |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Trello card
https://trello.com/c/Zo5khBtZ/7253
https://trello.com/c/ehr1u2a6/7303
Context
We reviewed our content guidance and saw opportunity to improve our guidance on redirects and accessibility.
Changes proposed in this pull request
Update guidance to include any missing advice.
Guidance to review