Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image updates #4526

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

image updates #4526

wants to merge 8 commits into from

Conversation

jenhadfield-dfe
Copy link
Contributor

Trello card

https://trello.com/c/6fdKlihw/7354-upload-new-campaign-images-and-add-to-site

Context

Changes proposed in this pull request

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code content Content changes labels Jan 29, 2025
@jenhadfield-dfe jenhadfield-dfe marked this pull request as ready for review February 5, 2025 13:51
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jenhadfield-dfe ! Just a few comments for you

@@ -26,7 +26,7 @@
title: "Explore subjects you could teach",
description: "Discover what you could teach, what teaching different subjects is really like, and how to take your next steps to become a teacher.",
path: "/life-as-a-teacher/explore-subjects",
image: "static/images/content/hero-images/physics_1383.jpg"
image: "static/images/content/hero-images/art-digital-painting.jpg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this image be better for the Change to a career in teaching section? This is currently the only one with a pupil on it rather than a teacher

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to still remove the image above due to the license but have updated the 'change to a career in teaching' image so its more consistent with the rest

docs/content.md Show resolved Hide resolved
config/images.yml Outdated Show resolved Hide resolved
Co-authored-by: Gemma Dallman <[email protected]>
Copy link

github-actions bot commented Feb 7, 2025

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config content Content changes Review ruby Pull requests that update Ruby code test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants