Remove the Teacher degree apprenticeship feature flag from Find & Publish #4597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All TDA feature flag checks was removed in these checks
Because we are on 2025 cycle :)
tomas-stefano
force-pushed
the
130-remove-the-tda-feature-flag-from-find-publish
branch
2 times, most recently
from
4ced79b to
c1a57c2
Compare
tomas-stefano
changed the title
To make sure back link points to the right page After the feature flag removal, the visa previous page: * Return to age group if user chosen further education * Return to university status if primary or secondary
tomas-stefano
force-pushed
the
130-remove-the-tda-feature-flag-from-find-publish
branch
from
c1a57c2 to
a0c89e8
Compare
Loooooks goooooood
inulty-dfe
approved these changes
Oct 16, 2024
tomas-stefano
deleted the
130-remove-the-tda-feature-flag-from-find-publish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Once the TDA work is live for a while and we are in the 2025 cycle, we should remove the feature flag and TDA checks.
Changes proposed in this pull request
Remove all feature flag checks for Find and Publish for teacher degree apprenticeship feature.
This means that:
Guidance to review
FeatureService.enabled?(:teacher_degree_apprenticeship)should befalse