Remove cross cycle code from 2024 to 2025

[inulty-dfe]

Context

We added some cycle year checks and tests. This PR cleans up those
cycle checks from these PRs

• [2304] Improve locations: 2/6 Add logic to hide school placements #4531
• [2282] Improve text 3/6 update location row on search result #4539

Changes proposed in this pull request

Remove Recruitment cycle specific testing
Stop checking for 2025 rcruitment cycle when showing the link to school placements in Find

Guidance to review

Things to check

• This code does not rely on migrations in the same Pull Request
• If this code includes a migration adding or changing columns, it also backfills existing records for consistency
• If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
• API release notes have been updated if necessary
• Required environment variables have been updated added to the Azure KeyVault
• Inform data insights team due to database changes
• Make sure all information from the Trello card is in here
• Rebased main
• Cleaned commit history
• Tested by running locally
• Attach PR to Trello card

[Nitemaeric]

LGTM, but I'd lean on another team dev to give a proper tick.

[tomas-stefano]

Should we cleanup this one? Or replace with RecruitmentCycle.current.year ?

spec/components/find/courses/training_locations/view_spec.rb
59:    let(:year) { 2025 }
62:    context 'when preview = true, before 2025 find opens and provider != selectable_school' do
64:      let(:year) { 2025 }
67:      it 'renders link to the publish path for 2025 provider' do
79:    context 'when preview is false after find opens in 2025 and provider has selectable_school enabled' do
80:      let(:year) { 2025 }

I also have another one but this might be redundant now that we are on 2025 🤔 🤔 🤔 can take a look tomorrow

spec/features/publish/courses/publishing_a_course_2025_spec.rb
8:  scenario 'i can publish a course in 2025' do
9:    given_the_current_recruitment_cycle_is_2025
23:  def given_the_current_recruitment_cycle_is_2025
24:    allow(Settings).to receive(:current_recruitment_cycle_year).and_return(2025)

[inulty-dfe]

Should we cleanup this one? Or replace with RecruitmentCycle.current.year ?

spec/components/find/courses/training_locations/view_spec.rb
59:    let(:year) { 2025 }
62:    context 'when preview = true, before 2025 find opens and provider != selectable_school' do
64:      let(:year) { 2025 }
67:      it 'renders link to the publish path for 2025 provider' do
79:    context 'when preview is false after find opens in 2025 and provider has selectable_school enabled' do
80:      let(:year) { 2025 }

I also have another one but this might be redundant now that we are on 2025 🤔 🤔 🤔 can take a look tomorrow

spec/features/publish/courses/publishing_a_course_2025_spec.rb
8:  scenario 'i can publish a course in 2025' do
9:    given_the_current_recruitment_cycle_is_2025
23:  def given_the_current_recruitment_cycle_is_2025
24:    allow(Settings).to receive(:current_recruitment_cycle_year).and_return(2025)

I'll pick this up tomorrow