Add selenium / system_test #4679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This file from Funding Mentors adds in mock OAuth https://github.com/DFE-Digital/itt-mentor-services/blob/main/spec/support/dfe_sign_in_user_helper.rb |
Nice one, thanks! I didn't understand how the OmniAuth mock was supposed to be used 👍 |
inulty-dfe
force-pushed
the
im/add-selenium-system-tests
branch
from
69e837f to
fd352df
Compare
inulty-dfe
force-pushed
the
im/add-selenium-system-tests
branch
from
a2e5f47 to
b0e949c
Compare
Setup system test drivers - default to rack-test - set rspec meta :js for headless javascript tests - set rspec meta :js_browser for browser launch
inulty-dfe
force-pushed
the
im/add-selenium-system-tests
branch
from
b0e949c to
2091ff3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Issues
Cannot yet run javascript tests in CI. Have not yet figured out how the chromedriver gets automatically installed by Selenium Manager.
Changes proposed in this pull request
Guidance to review
How can we get js tests running in CI?