Remove references to "_aks" environment names

[Nitemaeric]

Context

We've recently dropped "_aks" suffixes from AKS configurations.

We should remove the "_aks" suffixes from application code too.

Changes proposed in this pull request

• Remove previous non-aks environment configurations.
• Remove _aks suffix from environment names.

Guidance to review

Let's see if review works :D

[Nitemaeric]

Tech debt: Remove "_aks" suffixes from environment names

[tomas-stefano]

From the app point of view, looks good 👍

Is there anything we need to do on infra side or did they already remove references to _aks as well?

Such as copy/moving the settings.yml for each environment and so on?

[RMcVelia]

Could you also rename maintenance_page/manifests/env_aks to just env, or I can update on a separate pr if preferred.

[Nitemaeric]

Could you also rename maintenance_page/manifests/env_aks to just env, or I can update on a separate pr if preferred.

Done!

I'm curious about how it knows how to pick up the changes though. The workflow file has only production and qa as options, yet the directories were named production_aks and qa_aks. Was this a bug?

[RMcVelia]

Could you also rename maintenance_page/manifests/env_aks to just env, or I can update on a separate pr if preferred.

Done!

I'm curious about how it knows how to pick up the changes though. The workflow file has only production and qa as options, yet the directories were named production_aks and qa_aks. Was this a bug?

Thanks! The workflow would call env, but maintenance_page/scripts/failover.sh uses $CONFIG from global_config/env.sh which is now being changed from env_aks to env.