Make sure all logs in production has JSON format #4694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-stefano
added
the
deploy
tomas-stefano
commented
Nov 18, 2024
tomas-stefano
force-pushed
the
td/9-fix-logs-in-logit-for-publish
branch
from
f392005 to
0fe3fe4
Compare
Application name is blank so is an useless configuration
tomas-stefano
force-pushed
the
td/9-fix-logs-in-logit-for-publish
branch
from
788be72 to
ae5315c
Compare
In order to apply the JSON formatter this custom log needs to go. For the looks of it it is not doing anything that the normal log and filtering should do.
tomas-stefano
force-pushed
the
td/9-fix-logs-in-logit-for-publish
branch
from
93d12fa to
6e048f3
Compare
tomas-stefano
commented
Nov 20, 2024
|
|
||
| unless Rails.env.local? | ||
| Rails.application.configure do | ||
| config.semantic_logger.application = Settings.application_name |
There was a problem hiding this comment.
Removed this line because Settings.application_name is nil in all environments.
Nitemaeric
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Our logs are not well formatted in Logit.
Changes proposed in this pull request
Make sure logs has the JSON format.
Know issue
There is an issue with some of the logs when requests kicked in:
This is because of WEBrick logs. Soon we will be replacing WEBrick so I didn't solve this particular issue.
Guidance to review