Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove local SSL configurations #4699

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Remove local SSL configurations #4699

merged 1 commit into from
Nov 19, 2024

Conversation

Nitemaeric
Copy link
Contributor

Context

We don't need to setup SSL on our local machines. If we needed to test SSL locally, we can use a secure tunnelling service.

Changes proposed in this pull request

  • Remove all use_ssl references.
  • Remove SSL config in config/puma.rb.

Guidance to review

Try running rails s and bundle exec puma locally. Both should work.

@Nitemaeric Nitemaeric added the deploy A Review App will be created for PRs with this label label Nov 18, 2024
@Nitemaeric Nitemaeric self-assigned this Nov 18, 2024
@Nitemaeric Nitemaeric requested a review from a team as a code owner November 18, 2024 17:05
@Nitemaeric Nitemaeric merged commit 8141a46 into main Nov 19, 2024
38 checks passed
@Nitemaeric Nitemaeric deleted the dd/remove-local-ssl branch November 19, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-stefano tomas-stefano tomas-stefano approved these changes

Assignees

@Nitemaeric Nitemaeric

Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nitemaeric @tomas-stefano