Moving POROs out of app/models into app/lib #4704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gms-gs
force-pushed
the
gs/move-poros-to-lib-dir
branch
from
d3f9efc to
b8f89e9
Compare
gms-gs
force-pushed
the
gs/move-poros-to-lib-dir
branch
from
b8f89e9 to
740fdf6
Compare
tomas-stefano
approved these changes
Nov 21, 2024
Nitemaeric
reviewed
Nov 22, 2024
gms-gs
force-pushed
the
gs/move-poros-to-lib-dir
branch
from
ac93132 to
54d268a
Compare
Nitemaeric
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to be moving Plain Old Ruby Objects (POROs) out of app/models and into app/lib (or a similar directory like app/services, app/concerns, or app/utils) in our application as it is recommended for better organisation and separation of concerns
Changes proposed in this pull request
Guidance to review