Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially disable semantic logger in development #4706

Merged

Conversation

tomas-stefano
Copy link
Contributor

@tomas-stefano tomas-stefano commented Nov 21, 2024

Context

Disable partially the semantic logger in development in order to be as close as we can from Rails default in development.

Changes proposed in this pull request

Following semantic logger documentation and comment on the issue: reidmorrison/rails_semantic_logger#213

There is no way to disable entirely rails semantic logger without the require: false as the issue above described. I opt-in for the solution proposed in the issue above.

The image below are from the docs: https://logger.rocketjob.io/rails.html

Screenshot 2024-11-21 at 12 30 32

Guidance to review

  1. The review app logs in JSON?
  2. If you pull locally the logs are near to the Rails default as we can?

@tomas-stefano tomas-stefano added the deploy A Review App will be created for PRs with this label label Nov 21, 2024
@tomas-stefano tomas-stefano requested a review from a team as a code owner November 21, 2024 12:33
Copy link
Contributor

@Nitemaeric Nitemaeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried locally. It looks good.

Things I'd change:

  • Remove request_id from development. As far as I can tell, we're typically just making requests 1-by-1 ourselves.
  • Remove PID - I tried playing around with this one for a bit, but I can't seem to get it working without digging further.

@tomas-stefano tomas-stefano merged commit d85ed3b into main Dec 9, 2024
37 of 38 checks passed
@tomas-stefano tomas-stefano deleted the td/partially-disable-semantic-logger-in-development branch December 9, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants