Copy courses between providers in Support console #4750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inulty-dfe
force-pushed
the
im/copy-courses-between-providers
branch
2 times, most recently
from
5cc9ed6 to
77c8835
Compare
prevent error when element is not on screen
inulty-dfe
force-pushed
the
im/copy-courses-between-providers
branch
from
35fd5a2 to
fc162d3
Compare
add test for copying schools
inulty-dfe
force-pushed
the
im/copy-courses-between-providers
branch
from
fc162d3 to
6f006a7
Compare
inulty-dfe
force-pushed
the
im/copy-courses-between-providers
branch
4 times, most recently
from
f53bf6c to
7e27485
Compare
Cannot get chromedriver to run the tests on the Alpine image These packages are needed at least: gcompat glib nss libxcb libgcc chromium Selenium [:driver_service] polling for socket on ["127.0.0.1", 9515] The test fails when chromedriver cannot connect on the socket 2024-12-09 12:28:48 DEBUG Selenium [:driver_service] polling for socket on ["127.0.0.1", 9515]
inulty-dfe
force-pushed
the
im/copy-courses-between-providers
branch
from
7e27485 to
07eaba3
Compare
inulty-dfe
force-pushed
the
im/copy-courses-between-providers
branch
from
0022fe6 to
afcf251
Compare
| copier = ::Courses::CopyToProviderService.new(sites_copy_to_course:, enrichments_copy_to_course: Enrichments::CopyToCourseService.new, force: true) | ||
|
|
||
| Provider.transaction do | ||
| @copy_courses_form.provider.courses.map do |course| |
There was a problem hiding this comment.
On the PR description it mentions "Copy all courses or some courses" but here is all courses. Can we remove the "some courses" from description just to avoid confusion?
I assume the copying specific courses would be done on a later interaction when we will have a support ticket?
There was a problem hiding this comment.
Yeah I've not implemented "some courses" because unwanted courses can be deleted
| end | ||
| end | ||
|
|
||
| redirect_to support_recruitment_cycle_provider_path(recruitment_cycle.year, @copy_courses_form.target_provider.id) |
There was a problem hiding this comment.
Is there any indication everything went sucessfully? Should we add one?
There was a problem hiding this comment.
Screencast.from.10-12-24.10.47.38.webm
There was a problem hiding this comment.
I'll change it to redirect to the courses tab too
tomas-stefano
approved these changes
Dec 10, 2024
inulty-dfe
force-pushed
the
im/copy-courses-between-providers
branch
from
84d4eae to
4438f47
Compare
redirect to the courses tab after copy
inulty-dfe
force-pushed
the
im/copy-courses-between-providers
branch
from
4438f47 to
075b4b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Support are often asked to copy courses from one provider to another. This PR provides the ability for users to copy courses via the Support console.
Considerations
Changes proposed in this pull request
Screencast.from.09-12-24.15.27.18.webm
Guidance to review