Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SupportController to Support::ApplicationController #4760

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Rename SupportController to Support::ApplicationController #4760

merged 1 commit into from
Dec 16, 2024

Conversation

Nitemaeric
Copy link
Contributor

@Nitemaeric Nitemaeric commented Dec 11, 2024 •
edited
Loading

Context

We want to conventionalise base class naming conventions. For example:

  • Base models should be named ApplicationRecord.
  • Base controllers should be named ApplicationController.
  • Base mailers should be named ApplicationMailer.

Each namespace should have a base class implementation. For example:

  • Find::ApplicationController < ::ApplicationController and Support::ApplicationController < ::ApplicationController.

Changes proposed in this pull request

  • Rename Support::SupportController to Support::ApplicationController

Guidance to review

@Nitemaeric Nitemaeric force-pushed the dd/add-namespace-application-controllers branch from 2e4efa2 to cee27f7 Compare December 13, 2024 17:23
@Nitemaeric Nitemaeric self-assigned this Dec 13, 2024
@Nitemaeric Nitemaeric added the deploy A Review App will be created for PRs with this label label Dec 13, 2024
@Nitemaeric Nitemaeric marked this pull request as ready for review December 13, 2024 17:28
@Nitemaeric Nitemaeric requested a review from a team as a code owner December 13, 2024 17:28
tomas-stefano
tomas-stefano approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@tomas-stefano tomas-stefano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. The review apps are working (I was click around and searching and viewing and changing on support console and all good)

@Nitemaeric Nitemaeric merged commit dfe11b5 into main Dec 16, 2024
38 checks passed
@Nitemaeric Nitemaeric deleted the dd/add-namespace-application-controllers branch December 16, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-stefano tomas-stefano tomas-stefano approved these changes

Assignees

@Nitemaeric Nitemaeric

Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nitemaeric @tomas-stefano