Add the page title and the results summary to the v2 results #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-stefano
added
the
deploy
Nitemaeric
reviewed
Dec 12, 2024
Nitemaeric
reviewed
Dec 12, 2024
| @@ -7,6 +7,7 @@ class ResultsController < Find::ApplicationController | |||
|
|
|||
| def index | |||
| @courses = CoursesQuery.call(params:) | |||
| @courses_count = @courses.count | |||
There was a problem hiding this comment.
Do we need this variable? It feels like we could either call @courses.count or @pagy.count in the view directly. Is it to cache the value?
There was a problem hiding this comment.
Is it to cache the value?
Yes. I'd prefer this way
There was a problem hiding this comment.
We use this count two times in the view and will send also for tracking. I think would be good to have this value.
For a while I was thinking that maybe courses query could have this value but we don't hold the courses query instance so I chosen this way.
tomas-stefano
force-pushed
the
td/290-foundation-for-the-pre-filter-work-search-results-title-header
branch
from
79e96dd to
f218ac5
Compare
No courses found 1 course found X courses found 1,000 courses found
tomas-stefano
force-pushed
the
td/290-foundation-for-the-pre-filter-work-search-results-title-header
branch
from
f218ac5 to
23e857d
Compare
Nitemaeric
approved these changes
Dec 13, 2024
tomas-stefano
deleted the
td/290-foundation-for-the-pre-filter-work-search-results-title-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
On the new search results page we want to add the description of “x courses found” or “no courses found” and we want to add the page title as well.
Scenarios:
What this PR does NOT do yet
Handle the no courses found message inside the search results (this will be done at later stage when all filters are done).
Changes proposed in this pull request
Guidance to review