Improve filters - add secondary filter - within filter search functionality #4790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-stefano
added
the
deploy
|
Trello: https://trello.com/c/hnmuEiq8/53-improve-filters-add-secondary-filter (the Github integration is not working) |
tomas-stefano
changed the title
tomas-stefano
force-pushed
the
td/53-improve-filters-add-secondary-filter-part-2
branch
from
d5587b5 to
06a0685
Compare
Added the test for the secondary filters
Within the secondary filters we will allow the option search so if someone searches within the filter for "Bio" they will see only "Biology" option. Add the js and the stimulus and a start to switch to stimulus bit by bit.
Enabling in QA. The reason of the change is because Selenium doesn't play well with basic authentication Fix standard js errors
tomas-stefano
force-pushed
the
td/53-improve-filters-add-secondary-filter-part-2
branch
from
06a0685 to
9eb9d6f
Compare
tomas-stefano
commented
Dec 24, 2024
| <%= form.govuk_check_box :subjects, | ||
| subject.subject_code, | ||
| label: { text: subject.subject_name } %> | ||
| <% end %> |
There was a problem hiding this comment.
The govuk_collection_check_boxes with fieldset creates two classses govuk-checkboxes and create more divs and form groups which makes the JS not work as expected. (i would have to call children many times in the JS controller). So I changed to loop through the secondary subjets.
tomas-stefano
force-pushed
the
td/53-improve-filters-add-secondary-filter-part-2
branch
8 times, most recently
from
80f9b4d to
2b9da08
Compare
Nitemaeric
reviewed
Dec 30, 2024
Revert "Add playwright instead of selenium" This reverts commit 4a51dd3. Remove system specs from the build (for now) We are struggling with chromium and alpine
tomas-stefano
force-pushed
the
td/53-improve-filters-add-secondary-filter-part-2
branch
from
2b9da08 to
829ca1d
Compare
Nitemaeric
reviewed
Dec 30, 2024
tomas-stefano
force-pushed
the
td/53-improve-filters-add-secondary-filter-part-2
branch
from
67ca68e to
8351bb2
Compare
Nitemaeric
approved these changes
Dec 30, 2024
tomas-stefano
deleted the
td/53-improve-filters-add-secondary-filter-part-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds the "Search" within the filter.
After talking with the tech lead we decide to add Stimulus only for this component and gradually switch over Stimulus.
Changes proposed in this pull request
Guidance to review
config/settings/development.local.ymlhas:/v2/results