Change further education filter #4796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-stefano
added
the
deploy
tomas-stefano
force-pushed
the
td/change-further-education-filter
branch
from
d85c791 to
47438dd
Compare
This commit updates the handling of legacy parameters (`age_group` and `qualification`) to ensure compatibility when filtering by "further education" in the old v1 `/results` endpoint. - **SearchCoursesForm**: - Introduced `age_group` and `qualification` attributes. - Added methods to map old parameters (`age_group: 'further_education'` or `qualification: ['pgce pgde']`) to the `level: 'further_education'` parameter. - Ensures `search_params` excludes legacy parameters while still applying their equivalent filtering logic. - **CoursesQuery**: - Simplified logic for `further_education_scope` to focus on `level: 'further_education'`. If a user selects "further education" in the updated v2 filters, legacy v1 requests using 1. `age_group = further_education` (v1 second question) 2. `qualification = ['pgce pgde']` will continue to work. (v1 qualification filter when user chooses further education). This ensures backward compatibility while moving towards the new parameter conventions.
tomas-stefano
force-pushed
the
td/change-further-education-filter
branch
from
47438dd to
d258e3e
Compare
tomas-stefano
changed the title
Nitemaeric
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR changes the further education filter:
levelas parameter (to map the data modelling)Changes proposed in this pull request
Also changed the content of the filter as the trello card:
Guidance to review