Add Provider partnerships to training partners

[inulty-dfe]

Context

Accredited provider users can inspect their training partners in the Publish UI.
The list of Training providers is populated via the accredited providers ratifying of courses.

Changes proposed in this pull request

• URL changes from /training-providers to /training-partners
• AddCourseButton updated to work with provider partnerships
• AddCourseButtonEnrichments can be deleted when we migrate

Guidance to review

Course ratification has not been implemented yet so we cannot set an accredited partner to be the ratifying provider for a course yet.

The review app has provider partnerships enabled.

Training partners

Training partners courses

Trello

https://trello.com/c/kA22cSN0/393-add-providerpartnerships-to-training-partners

[tomas-stefano]

Can we simplify by going direct on the view?

<li>
  <%= govuk_link_to(add_school_text, school_path) %>
  <%= govuk_link_to(add_accredited_partner, add_accredited_partner_path) %>
</li>

Then the component will be more simple to read and understand.

Or another alternative to use functional?

def incomplete_sections
   conditions = {
      school: -> { provider.sites.empty? },
      accredited_partner: -> { !(provider.accredited_provider? || provider.accredited_partners.any?) }
    }

    conditions
      .select { |_key, predicate| predicate.call }
      .map { |key, _| build_section(key) }
  end

  private

  def build_section(key)
    Section.new(
      name: I18n.t("incomplete_sections.#{key}.name"),
      path: send("#{key}_path")
    )
  end
  
  def school_path
    ...
  end

   def accredited_partner_path
  ....
   end

[inulty-dfe]

@tomas-stefano I've made a change to the AddCourseButton. Tell me if you're happy enough to proceed

I Changed the partnerships version to AddCourseButton from AddCourseButtonPartnerships. And changed the one we'll delete later from AddCourseButton to AddCourseButtonEnrichments.
I've also simplified the logic in the component dramatically, I think.

[tomas-stefano]

Suggested change

	provider.accredited_providers.any?
	accredited_provider? || provider.accredited_providers.any?

[tomas-stefano]

Can this simplified by the same idea? https://github.com/DFE-Digital/publish-teacher-training/pull/4842/files#r1926738703

[inulty-dfe]

This is getting deleted after the switch to provider partnerships

[tomas-stefano]

Minor non blocking comments but all good to me