Replace Support and Advice in Find for TDA courses #4876
Conversation
inulty-dfe
force-pushed
the
im/39-update-support-callout-box-for-tda-courses
branch
from
a8430aa to
7cd4936
Compare
| @@ -209,6 +209,11 @@ en: | |||
| uk_citizens: UK citizens | |||
| non_uk_citizens: Non-UK citizens | |||
| course_fees: The course fees for UK citizens in %{cycle_range} are %{fee}. | |||
| tda_advice: | |||
| heading: Teacher degree apprenticeships (TDAs) | |||
| content: On a teacher degree apprenticeship you’ll work in a school and earn a salary while getting a bachelor’s degree and qualified teacher status (QTS). | |||
There was a problem hiding this comment.
we have a similar content on, can we use?
232: tda_with_qts_content_html: On a teacher degree apprenticeship you’ll work in a school and earn a salary while getting a bachelor’s degree and qualified teacher status (QTS). %{tda_link}
There was a problem hiding this comment.
They're in different components. I don't think it's worth the effort to make them the same value. They could easily change and that would be harder
There was a problem hiding this comment.
If the text belongs to the components, let's keep them separate.
TDA courses are not the responsibility of GiT. We do not want to invite candidates to seek advice from GiT for these courses
inulty-dfe
force-pushed
the
im/39-update-support-callout-box-for-tda-courses
branch
from
7cd4936 to
fd49fbc
Compare
| @@ -209,6 +209,11 @@ en: | |||
| uk_citizens: UK citizens | |||
| non_uk_citizens: Non-UK citizens | |||
| course_fees: The course fees for UK citizens in %{cycle_range} are %{fee}. | |||
| tda_advice: | |||
| heading: Teacher degree apprenticeships (TDAs) | |||
| content: On a teacher degree apprenticeship you’ll work in a school and earn a salary while getting a bachelor’s degree and qualified teacher status (QTS). | |||
There was a problem hiding this comment.
If the text belongs to the components, let's keep them separate.
| #section-advice-and-support, | ||
| #section-tda-advice { |
There was a problem hiding this comment.
Can we use classes for styling instead of IDs please?
inulty-dfe
deleted the
im/39-update-support-callout-box-for-tda-courses
branch
Context
TDA courses are not the responsibility of GiT. We do not want to
invite candidates to seek advice from GiT for these courses
Changes proposed in this pull request
Create new partial that gets rendered to the Course page instead of the Support and Advice partial when the course is a TDA course.
Reuse existing styles but apply them to a new id selector.
Guidance to review
TDA course on Review App
Trello
https://trello.com/c/lL4j73nC/39-update-support-callout-box-for-tda-courses