Improve navigation - Update Browse primary courses page #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gms-gs
force-pushed
the
307-improve-navigation-update-browse-primary-courses-page
branch
7 times, most recently
from
1cc893b to
36720fb
Compare
|
LGTM! |
gms-gs
force-pushed
the
307-improve-navigation-update-browse-primary-courses-page
branch
from
36720fb to
bd9805e
Compare
gms-gs
force-pushed
the
307-improve-navigation-update-browse-primary-courses-page
branch
from
bd9805e to
4cfc198
Compare
gms-gs
deleted the
307-improve-navigation-update-browse-primary-courses-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Prototype: https://find-review-4453.test.teacherservices.cloud/subjects?age_group=primary
Ticket: https://trello.com/c/lolKTP1k/307-improve-navigation-update-browse-primary-courses-page
The basis of this ticket is to pretty much change some content, however Dan, Tomas and I have agreed we want to simplify the code for this. So we have gone with a v2 line for this work which will rework what we currently have to become easier to maintain and extend.
This PR creates a
SubjectsControllerwhich will be responsible for the primary and secondary subject rendering (Only primary for this ticket, subjects is in an upcoming ticket), I also added aPrimarySubjectsFormwhich just ensures an option is checked before processing to the new v2 results page.Changes proposed in this pull request
Browse primary coursesquick link to take the user to the newv2/primaryroute instead of the old routeGuidance to review
No errors:
With errors:
