Merge pull request #64 from DFE-Digital/fix-success-page

Remove title and render teacher name when recording outcome
DFE-Digital · Jan 22, 2025 · 48dc902 · 48dc902
2 parents d0baf1c + d03ec3a
commit 48dc902
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/app/views/appropriate_bodies/teachers/record_failed_outcome/show.html.erb b/app/views/appropriate_bodies/teachers/record_failed_outcome/show.html.erb
@@ -1,5 +1,3 @@
-<% page_data(title: "Success") %>
-
 <%= govuk_panel(
   title_text: "Success",
   text: "You have recorded a failing outcome for #{@teacher_name}"

diff --git a/app/views/appropriate_bodies/teachers/record_passed_outcome/new.html.erb b/app/views/appropriate_bodies/teachers/record_passed_outcome/new.html.erb
@@ -2,5 +2,5 @@
 
 <%= form_with(model: @pending_induction_submission, url: ab_teacher_record_passed_outcome_path(@teacher), method: 'post') do |f| %>
   <%= render partial: 'appropriate_bodies/teachers/outcome_form', locals: { f: f } %>
-  <%= f.govuk_submit "Record passing outcome for #{Teachers::Name.new(@teacher).full_name}" %>
+  <%= f.govuk_submit "Record pass outcome for #{Teachers::Name.new(@teacher).full_name}" %>
 <% end %>
diff --git a/app/views/appropriate_bodies/teachers/record_passed_outcome/show.html.erb b/app/views/appropriate_bodies/teachers/record_passed_outcome/show.html.erb
@@ -1,8 +1,6 @@
-<% page_data(title: "Success") %>
-
 <%= govuk_panel(
   title_text: "Success",
-  text: "You have recorded a passing outcome for #{Teachers::Name.new(@teacher).full_name}"
+  text: "You have recorded a pass outcome for #{@teacher_name}"
 ) %>
 
 <%= govuk_button_link_to("Return to the homepage", ab_teachers_path, secondary: true) %>
diff --git a/spec/features/appropriate_bodies/record_passed_outcome_spec.rb b/spec/features/appropriate_bodies/record_passed_outcome_spec.rb
@@ -54,7 +54,7 @@ def and_i_enter_a_terms_value_of(number)
 
   def and_i_click_submit
     teacher_name = Teachers::Name.new(teacher).full_name
-    page.get_by_role('button', name: "Record passing outcome for #{teacher_name}").click
+    page.get_by_role('button', name: "Record pass outcome for #{teacher_name}").click
   end
 
   def then_i_should_be_on_the_success_page