Fix nav highlights in admin area #28
Open
+14
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the nav we're nesting schools, ABs, DPs and LPs beneath organisations so it makes sense for us to do it in the routes too, to keep things consistent. Also, there's no /admin page, we render admin/teachers here instead. This means the nav won't know what's actually being shown (without us hardcoding extra behaviour) so let's redirect instead.
This sets active to true for nav nodes when the beginning of the current_path matches the active when path.
|
Review app deployed to https://cpd-ec2-review-28-web.test.teacherservices.cloud |
tonyheadford
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when we're deeply into the nested structure the primary nav highlights properly.
Changes
/adminto/admin/teachersinstead of just rendering the teachers list on/adminactive_whenargs to the service nav so nav items are appropriately highlighted