Prevent induction start dates that are too early #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://cpd-ec2-review-47-web.test.teacherservices.cloud |
edujackedu
approved these changes
Jan 20, 2025
peteryates
force-pushed
the
prevent-induction-period-start-dates-that-are-too-early
branch
from
b1407da to
d7aa2bb
Compare
|
@peteryates I tested this with TRN 3002585 and a date pre-September 2021 and just got one of these: |
peteryates
force-pushed
the
prevent-induction-period-start-dates-that-are-too-early
branch
from
d7aa2bb to
d309f30
Compare
|
@emily-prudence-dfe - I've fixed this and made as much of the validation overlaps between pending induction submissions and induction periods shared (rather than duplicated) so hopefully this works a bit better. |
edujackedu
reviewed
Jan 24, 2025
edujackedu
approved these changes
Jan 24, 2025
peteryates
force-pushed
the
prevent-induction-period-start-dates-that-are-too-early
branch
from
d309f30 to
4e0d1b6
Compare
|
@peteryates @emily-prudence-dfe reviewed this and all looks good, re-tried with the TRN Emily had problems with and validation error appears as it should. Happy to merge. |
There's a chance we'll want to allow some earlier dates when importing so maybe we should relax this rule for the migration.
Induction periods and pending induction submissions share a lot of validation and we didn't have them perfectly aligned, which caused many bugs. This change introduces a shared place to put common validation, which should hopefully make things easier to manage in the future.
peteryates
force-pushed
the
prevent-induction-period-start-dates-that-are-too-early
branch
from
4e0d1b6 to
318f386
Compare
peteryates
deleted the
prevent-induction-period-start-dates-that-are-too-early
branch
|
Review app ECF2 deployed to https://ec2-review-47-web.test.teacherservices.cloud was deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose 1 September 2021 as the cutoff. Seems sensible but happy to change if there's a cause to be creating them before then.