Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

770 adjust db monitoring #3783

Closed
wants to merge 1 commit into from
Closed

770 adjust db monitoring #3783

wants to merge 1 commit into from

Conversation

johnake
Copy link
Contributor

@johnake johnake commented Nov 24, 2023

Context

Add evaluation_total_count to postgres snapshot for prod env

Guidance to review

Important business

  • Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
  • Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
  • Do we need to send any updates to DQT as part of the work in this PR?
  • Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

@johnake
Copy link
Contributor Author

johnake commented Nov 24, 2023

Adjust DB monitoring

@johnake johnake added the DevOps label Nov 24, 2023
defong
defong reviewed Nov 24, 2023
View reviewed changes
terraform/aks/workspace-variables/production_aks.tfvars.json Outdated
@@ -34,6 +34,7 @@
"azure_tempdata_storage_account_name": "s189p01registerpdtmp",
"azure_resource_group_name": "s189p01-rtt-pd-rg",
"azure_storage_account_replication_type": "RAGRS",
"evaluation_total_count": 29,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 29?

@johnake johnake force-pushed the 770-adjust-db-monitoring branch 2 times, most recently from b18fe34 to 6687a42 Compare November 27, 2023 14:18
@johnake johnake force-pushed the 770-adjust-db-monitoring branch from 6687a42 to e205a9d Compare November 28, 2023 09:54
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johnake
Copy link
Contributor Author

johnake commented Dec 4, 2023

Another PR open

@johnake johnake closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defong defong defong left review comments

Assignees
No one assigned
Labels
DevOps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnake @defong