Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6465] Amended wordings #3806

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[6465] Amended wordings #3806

merged 1 commit into from
Dec 1, 2023

Conversation

defong
Copy link
Contributor

@defong defong commented Dec 1, 2023 •
edited
Loading

Context

Wordings

Changes proposed in this pull request

This wording is needed instead of previous one

You need to add the details of at least 2 schools. These can be added at any time.

Guidance to review

image

Important business

  • Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
  • Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
  • Do we need to send any updates to DQT as part of the work in this PR?
  • Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@defong
Copy link
Contributor Author

defong commented Dec 1, 2023

Bug party 4: update Confirm Placement screen

darokel
darokel approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@darokel darokel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@defong defong merged commit 33f83d8 into main Dec 1, 2023
62 checks passed
@defong defong deleted the 6465-bug-party-4-update-confirm-placement-screen-part-2 branch December 1, 2023 10:52
@andrewscrivener
Copy link
Collaborator

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darokel darokel darokel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@defong @andrewscrivener @darokel