Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6400] bulk placements create records pending import records #3807

Merged
merged 12 commits into from
Dec 5, 2023
Merged

[6400] bulk placements create records pending import records #3807

merged 12 commits into from
Dec 5, 2023

Conversation

d-a-v-e
Copy link
Contributor

@d-a-v-e d-a-v-e commented Dec 1, 2023

Context

  • We need to create placement rows for each csv row uploaded.
  • multiple rows are created for a single csv row
  • this is determined by the number of placement urns in a single row
  • these rows will later be used to create the actual placement records between a trainee and a school

Changes proposed in this pull request

  • adds service for creating placement rows after uploading a csv

Guidance to review

  • download the template after logging in as Annie Bell persona
  • add some URNs
  • upload and check the bulk_update_placement_rows table for new entries

@d-a-v-e d-a-v-e requested a review from a team December 1, 2023 17:36
defong
defong reviewed Dec 4, 2023
View reviewed changes
config/analytics_blocklist.yml Show resolved Hide resolved
spec/factories/bulk_update/placement_rows.rb Outdated Show resolved Hide resolved
spec/factories/bulk_update/placement_rows.rb Outdated Show resolved Hide resolved
spec/factories/bulk_update/placement_rows.rb Outdated Show resolved Hide resolved
@d-a-v-e d-a-v-e mentioned this pull request Dec 4, 2023
Merged
@carlosmartinez
Copy link
Collaborator

looking good! just a couple of comments/questions

@d-a-v-e d-a-v-e force-pushed the 6400-bulk-placements-create-records-1-parse-and-store-upload-import-records branch from ba062db to 0dc1f3b Compare December 5, 2023 12:27
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@d-a-v-e
Copy link
Contributor Author

d-a-v-e commented Dec 5, 2023

Bulk placements create records 1: parse and store upload import records

@d-a-v-e d-a-v-e merged commit 76f573c into main Dec 5, 2023
32 checks passed
@d-a-v-e d-a-v-e deleted the 6400-bulk-placements-create-records-1-parse-and-store-upload-import-records branch December 5, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defong defong defong approved these changes

@carlosmartinez carlosmartinez carlosmartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-a-v-e @carlosmartinez @defong