[8074] Remove redirect from education.gov.uk domain
#4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehook
force-pushed
the
8074-remove-in-app-redirect-from-educationgovuk-domain
branch
from
3541ec7 to
5cef677
Compare
tomtrentham
reviewed
Jan 29, 2025
There was a problem hiding this comment.
Do we need to fix/remove some tests? https://github.com/DFE-Digital/register-trainee-teachers/actions/runs/13015587793/job/36304017874?pr=4995
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4995 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 763 763
Lines 16329 16329
=======================================
Hits 15711 15711
Misses 618 618
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is redirected at the infrastructure level now, to `service.gov.uk`. I've deleted the redirect entirely together with it's feature flag, rather than just switching off the feature flag.
stevehook
force-pushed
the
8074-remove-in-app-redirect-from-educationgovuk-domain
branch
from
77ea440 to
cd14efd
Compare
|
stevehook
deleted the
8074-remove-in-app-redirect-from-educationgovuk-domain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is redirected at the infrastructure level now, to
service.gov.uk.Changes proposed in this pull request
Remove the redirect and the associated feature flag.
Guidance to review
I've deleted the redirect entirely together with it's feature flag, rather than just switching off the flag.
Important business
NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml