[7957] Update HESA placements import #4999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomtrentham
force-pushed
the
7957-load-hei-placement-data-into-register
branch
from
50ec00a to
848ee05
Compare
|
Looks good, but it feels like it should include and update to the spec as well just to demonstrate that it does what it's supposed to. |
Reyko
reviewed
Jan 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4999 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 763 763
Lines 16329 16339 +10
=======================================
+ Hits 15711 15721 +10
Misses 618 618
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tomtrentham
force-pushed
the
7957-load-hei-placement-data-into-register
branch
2 times, most recently
from
3656aa1 to
0a0b456
Compare
tomtrentham
temporarily deployed
to
productiondata
GitHub Actions
Inactive
tomtrentham
temporarily deployed
to
productiondata
GitHub Actions
Inactive
tomtrentham
force-pushed
the
7957-load-hei-placement-data-into-register
branch
from
0a0b456 to
4c5a1be
Compare
- support NOT_APPLICABLE_SCHOOL_URNS - provide feedback from rake task
tomtrentham
force-pushed
the
7957-load-hei-placement-data-into-register
branch
from
4c5a1be to
d67c953
Compare
|
Reyko
approved these changes
Jan 31, 2025
defong
approved these changes
Jan 31, 2025
kennyevil
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Trello card
Changes proposed in this pull request
NOT_APPLICABLE_SCHOOL_URNSas we do when placements come from the main HESA integrationGuidance to review
Important business
NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml