Tidy test anomalies (#7462)

spec/models/jobseeker_profile_spec.rb

@@ -65,7 +65,7 @@
     it "does not delete qualifications unrelated to the profile" do
       unrelated_qualification = create(:qualification)
       profile.replace_qualifications!(new_qualifications)
-      expect { unrelated_qualification.reload }.not_to raise_error(ActiveRecord::RecordNotFound)
+      expect { unrelated_qualification.reload }.not_to raise_error
     end
   end
 
@@ -87,7 +87,7 @@
     it "does not delete employments unrelated to the profile" do
       unrelated_employment = create(:employment)
       profile.replace_employments!(new_employments)
-      expect { unrelated_employment.reload }.not_to raise_error(ActiveRecord::RecordNotFound)
+      expect { unrelated_employment.reload }.not_to raise_error
     end
   end
 end

spec/support/matchers/have_delivered_notification.rb

@@ -17,7 +17,7 @@
       params: (hash_including(expected_params) if expected_params),
     }
 
-    expect(proc).to change { Noticed::Notification.count }.by(1)
+    expect { proc.call }.to change { Noticed::Notification.count }.by(1)
 
     notification = Noticed::Notification.last
     event = Noticed::Event.find(notification.event_id)

spec/support/vacancy_helpers.rb

@@ -197,7 +197,7 @@ def verify_all_vacancy_details(vacancy)
     vacancy.working_patterns.each do |working_pattern|
       expect(page).to have_content(/#{working_pattern.humanize}/i)
     end
-    expect(page).to have_content(vacancy.working_patterns_details)
+    expect(page).to have_content(vacancy.working_patterns_details) if vacancy.working_patterns_details.present?
 
     expect(page).to have_content(vacancy.salary) if vacancy.salary_types.include?("full_time")
     expect(page).to have_content(vacancy.actual_salary) if vacancy.salary_types.include?("part_time")

spec/system/jobseekers/jobseekers_can_transfer_data_from_old_account_spec.rb

@@ -177,6 +177,6 @@ def expect_account_to_be_populated_with_old_account_data
     visit jobseekers_subscriptions_path
 
     expect(page).not_to have_content "You have no job alerts set up"
-    expect(page).to have_content subscription.search_criteria["keyword"]
+    expect(page).to have_content subscription.search_criteria.fetch("keyword", "")
   end
 end

spec/system/publishers/publishers_can_add_notes_to_a_job_application_spec.rb

@@ -10,6 +10,8 @@
 
   before { login_publisher(publisher: publisher, organisation: organisation) }
 
+  after { logout }
+
   it "shows the current notes" do
     visit organisation_job_job_application_path(vacancy.id, job_application)