Faith Schools Flow Target branch #7230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starswan
force-pushed
the
faith-schools-flow
branch
2 times, most recently
from
b05a974 to
b2c49e7
Compare
EllieNodder
reviewed
Nov 20, 2024
starswan
force-pushed
the
faith-schools-flow
branch
2 times, most recently
from
d03f02e to
7ebf923
Compare
starswan
force-pushed
the
faith-schools-flow
branch
2 times, most recently
from
c22557f to
3528559
Compare
EllieNodder
reviewed
Dec 11, 2024
EllieNodder
reviewed
Dec 11, 2024
starswan
force-pushed
the
faith-schools-flow
branch
from
08ab7a0 to
4144574
Compare
EllieNodder
reviewed
Dec 12, 2024
EllieNodder
reviewed
Dec 12, 2024
EllieNodder
reviewed
Dec 12, 2024
EllieNodder
reviewed
Dec 12, 2024
EllieNodder
reviewed
Dec 12, 2024
scruti
reviewed
Dec 12, 2024
scruti
reviewed
Dec 12, 2024
scruti
reviewed
Dec 13, 2024
spec/system/publishers/publishers_can_publish_a_vacancy_as_a_school_spec.rb
Show resolved
Hide resolved
scruti
reviewed
Dec 13, 2024
app/services/jobseekers/job_applications/prefill_job_application_from_previous_application.rb
Outdated
Show resolved
Hide resolved
scruti
reviewed
Dec 13, 2024
app/services/jobseekers/job_applications/prefill_job_application_from_previous_application.rb
Show resolved
Hide resolved
scruti
reviewed
Dec 13, 2024
scruti
reviewed
Dec 13, 2024
starswan
force-pushed
the
faith-schools-flow
branch
from
89b874d to
6cc707e
Compare
starswan
force-pushed
the
faith-schools-flow
branch
2 times, most recently
from
6ea7215 to
e5a0b6e
Compare
scruti
reviewed
Jan 10, 2025
Comment on lines
44
to
58
| def all_possible_steps | ||
| steps = case job_application.vacancy.religion_type | ||
| when "catholic" | ||
| PRE_RELIGION_STEPS.merge(religious_information: ALL_CATHOLIC_STEPS).merge(POST_RELIGION_STEPS) | ||
| when "other_religion" | ||
| PRE_RELIGION_STEPS.merge(religious_information: ALL_NON_CATHOLIC_STEPS).merge(POST_RELIGION_STEPS) | ||
| else | ||
| PRE_RELIGION_STEPS.merge(POST_RELIGION_STEPS) | ||
| end | ||
| steps.values.flatten | ||
| end |
starswan
force-pushed
the
faith-schools-flow
branch
3 times, most recently
from
39e04e6 to
edc1c59
Compare
starswan
force-pushed
the
faith-schools-flow
branch
2 times, most recently
from
5a1777f to
8177c75
Compare
starswan
force-pushed
the
faith-schools-flow
branch
from
8177c75 to
eaeb984
Compare
Co-authored-by: EllieNodder <[email protected]>
Co-authored-by: EllieNodder <[email protected]>
Co-authored-by: EllieNodder <[email protected]>
…on_from_previous_application.rb Co-authored-by: Marc Sardón <[email protected]>
Co-authored-by: Marc Sardón <[email protected]>
starswan
force-pushed
the
faith-schools-flow
branch
from
8f4c6d6 to
708689f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
Changes in this PR:
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?