Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify DfE::Analytics behaviour on development #7331

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −2
Draft

Simplify DfE::Analytics behaviour on development #7331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
573b6e5
Run DfE::Analytics in "log only" mode in Dev.
scruti Dec 4, 2024
96a89b6
Disable DfE::Analytics async jobs on Development
scruti Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .env.development
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
DFE_ANALYTICS_ASYNC=false
DFE_ANALYTICS_LOG_ONLY=true
DFE_SIGN_IN_REDIRECT_URL=http://localhost:3000/auth/dfe/callback
DISABLE_EMAILS=false
DOCUMENTS_S3_BUCKET=test_bucket
Expand Down
4 changes: 2 additions & 2 deletions config/initializers/dfe_analytics.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
DfE::Analytics.configure do |config|
# Whether to log events instead of sending them to BigQuery.
#
config.log_only = false
config.log_only = ActiveModel::Type::Boolean.new.cast(ENV.fetch("DFE_ANALYTICS_LOG_ONLY", false))

# Whether to use ActiveJob or dispatch events immediately.
#
config.async = true
config.async = ActiveModel::Type::Boolean.new.cast(ENV.fetch("DFE_ANALYTICS_ASYNC", false))

# Which ActiveJob queue to put events on
#
Expand Down