Job alerts overlap testing

app/jobs/alert_email/base.rb

@@ -14,6 +14,6 @@ def perform
   end
 
   def vacancies_for_subscription(subscription)
-    subscription.vacancies_for_range(from_date, Date.current)
+    subscription.vacancies_for_range(from_date, Date.yesterday)
   end
 end

app/jobs/send_daily_alert_email_job.rb

@@ -6,6 +6,6 @@ def subscriptions
   end
 
   def from_date
-    Time.zone.yesterday
+    2.days.ago.to_date
   end
 end

app/jobs/send_weekly_alert_email_job.rb

@@ -6,6 +6,6 @@ def subscriptions
   end
 
   def from_date
-    1.week.ago.to_date
+    8.days.ago.to_date
   end
 end

config/schedule.yml

@@ -51,7 +51,7 @@ queue_applications_received:
   queue: default
 
 queue_daily_alerts:
-  cron: '0 15 * * *'
+  cron: '30 08 * * *'
   class: 'SendDailyAlertEmailJob'
   queue: default
 

spec/jobs/send_daily_alert_email_job_spec.rb

@@ -69,7 +69,7 @@
     let(:job) { described_class.new }
 
     it "gets vacancies in the last day" do
-      expect(subscription).to receive(:vacancies_for_range).with(Time.zone.yesterday, Date.current) { Vacancy.none }
+      expect(subscription).to receive(:vacancies_for_range).with(2.days.ago.to_date, Date.yesterday) { Vacancy.none }
       job.vacancies_for_subscription(subscription)
     end
   end

spec/jobs/send_weekly_alert_email_job_spec.rb

@@ -69,7 +69,7 @@
     let(:job) { described_class.new }
 
     it "gets vacancies in the last week" do
-      expect(subscription).to receive(:vacancies_for_range).with(1.week.ago.to_date, Date.current) { Vacancy.none }
+      expect(subscription).to receive(:vacancies_for_range).with(8.days.ago.to_date, Date.yesterday) { Vacancy.none }
       job.vacancies_for_subscription(subscription)
     end
   end

terraform/workspace-variables/review_app_env.yml

@@ -6,7 +6,7 @@ BIGQUERY_DATASET: staging_dataset
 DFE_SIGN_IN_REGISTRATION_URL: https://test-profile.signin.education.gov.uk/register
 DISABLE_DATABASE_ENVIRONMENT_CHECK: 1
 DISABLE_EMAILS: false
-DISABLE_EXPENSIVE_JOBS: true
+DISABLE_EXPENSIVE_JOBS: false
 ENFORCE_LOCAL_AUTHORITY_ALLOWLIST: false
 RAILS_ENV: production
 RAILS_LOG_TO_STDOUT: true