Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple CMake warnings #379

Merged
merged 4 commits into from
May 13, 2024
Merged

Fix multiple CMake warnings #379

merged 4 commits into from
May 13, 2024

Conversation

jarkenau
Copy link
Member

@jarkenau jarkenau commented May 3, 2024

Summary:

  • Downgrade CMake to a version distributed with Ubuntu 20.04 due to incompatibilities with ROS noetic
  • Fix CMake warnings generated by CGAL
  • Remove unused dependencies from Docker base image

Some warnings will still be around:

 warning: missing initializer for member ‘seerep_hdf5_core::ImageAttributes::cameraIntrinsicsUuid’ [-Wmissing-field-initializers]

seerep_hdf5_py has to be updated to support camera intrinsic #305

warning: unused parameter ‘options’ [-Wunused-parameter]
   25 | std::unique_ptr< ImageService::Stub> ImageService::NewStub(const std::shared_ptr< ::grpc::ChannelInterface>& channel, const ::grpc::StubOptions& options) 
...

The code is generated by flatc. Maybe updating to a more recent version would help? Something for a different PR.

jarkenau added 3 commits May 3, 2024 10:04
removes the following warning:

> Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules are removed.
> Run "cmake --help-policy CMP0148" for policy details.
> Use the cmake_policy command to set the policy and suppress this warning.
@jarkenau jarkenau self-assigned this May 3, 2024
@jarkenau jarkenau force-pushed the fix/cmake-warnings branch from d07fabe to 7c91956 Compare May 3, 2024 14:16
@jarkenau jarkenau merged commit a5d0bc4 into main May 13, 2024
9 checks passed
@jarkenau jarkenau deleted the fix/cmake-warnings branch May 13, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants