make terracotta python 3.12 compatible #346
Open
+31
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix deprecation/removal of pkg_resources and rasterio is_tiled
dionhaefner
requested changes
Oct 23, 2024
Comment on lines
+54
to
+57
| if not ( | ||
| src.block_shapes | ||
| and all(src.width != w for _, w in src.block_shapes) | ||
| ): |
There was a problem hiding this comment.
Please add a function is_tiled instead, and indicate where this code comes from (copy-paste from rasterio?)
| import importlib | ||
|
|
||
| import terracotta.cmaps.get_cmaps | ||
|
|
||
| def throw_error(*args, **kwargs): | ||
| raise pkg_resources.DistributionNotFound("monkeypatched") | ||
| raise ModuleNotFoundError |
There was a problem hiding this comment.
Suggested change
| raise ModuleNotFoundError | |
| raise ModuleNotFoundError("monkeypatched") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix deprecation/removal of pkg_resources and rasterio is_tiled
if we were to drop 3.8 which is now EOL we wouldn't need the additional dependency of
importlib_resourcesand the if/else imports.