Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Drop the system instance level in the CS #7186

Merged
merged 7 commits into from
Sep 26, 2024

Conversation

atsareg
Copy link
Contributor

@atsareg atsareg commented Sep 5, 2023

This PR allows to drop the System instance section level from the CS. The presence of the /DIRAC/NoSetup=True option in the CS suggests that the configuration is defined without Setups (to be introduced in 9.0 #7671). This forces the system section not to contain the instance level in the output of getSystemSection() and similar cases. This way it should be compatible with CS both with and without Setups defined.

BEGINRELEASENOTES

*Configuration
CHANGE: PathFinder.getSystemInstance() returns empty string if Setups are dropped from the CS

*WorkloadManagement
CHANGE: StalledJobAgent, Watchdog - use getSystemSection() instead of getSystemInstance()

ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Sep 5, 2023
@atsareg atsareg marked this pull request as draft September 8, 2023 14:13
@atsareg atsareg removed the alsoTargeting:integration Cherry pick this PR to integration after merge label Sep 13, 2024
@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Sep 13, 2024
@atsareg atsareg removed the alsoTargeting:integration Cherry pick this PR to integration after merge label Sep 13, 2024
@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Sep 13, 2024
@atsareg atsareg removed the alsoTargeting:integration Cherry pick this PR to integration after merge label Sep 13, 2024
@atsareg atsareg marked this pull request as ready for review September 14, 2024 00:34
@fstagni
Copy link
Contributor

fstagni commented Sep 19, 2024

So, IIUC:

  • this PR can be merged, deployed, and nothing should happen
  • at some point in time, the admins should:
    • set the DIRAC/NoSetup=True AND
    • remove the Systems part of CS to remove the instance parts
    • the /DIRAC/Setups part of CS can be entirely removed
  • at this point update to v9 can happen "freely"

At a minimum we need some instructions, to be added to the v9 wiki. A script that does the CS update would be better.

@atsareg
Copy link
Contributor Author

atsareg commented Sep 25, 2024

OK, agreed that the instruction should be added to the #7671 and I can make a simple script to update the CS. But this is part of the 9.0 update. So, this PR is safe to merge by anticipation of future changes. It is also needed to pass backward compatibility integration tests in #7671.

@fstagni
Copy link
Contributor

fstagni commented Sep 26, 2024

OK, agreed that the instruction should be added to the #7671 and I can make a simple script to update the CS. But this is part of the 9.0 update. So, this PR is safe to merge by anticipation of future changes. It is also needed to pass backward compatibility integration tests in #7671.

OK, I created #7808 in order to not forget.

@fstagni fstagni merged commit 4cbaf34 into DIRACGrid:rel-v8r0 Sep 26, 2024
26 checks passed
@DIRACGridBot DIRACGridBot added the sweep:ignore Prevent sweeping from being ran for this PR label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep:ignore Prevent sweeping from being ran for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants